Update targets and images to use our internal golang 1.9 images #129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liztio
approved these changes
Nov 6, 2017
| @@ -33,7 +33,7 @@ IMAGE_BRANCH ?= $(shell git rev-parse --abbrev-ref HEAD | sed 's/\///g') | |||
| GIT_REF = $(shell git rev-parse --short=8 --verify HEAD) | |||
|
|
|||
| BUILDMNT = /go/src/$(GOTARGET) | |||
| BUILD_IMAGE ?= golang:1.8 | |||
| BUILD_IMAGE ?= gcr.io/heptio-images/golang:1.9-alpine3.6 | |||
There was a problem hiding this comment.
I feel like this change should have a little more pomp and circumstance than it does. Maybe a note in the changelog about "targetting Go 1.9 now?"
|
One suggestion, nothing blocking |
Signed-off-by: Timothy St. Clair <timothysc@gmail.com>
timothysc
force-pushed
the
target-update
branch
from
47b5fde
to
2a4eb84
Compare
timothysc
changed the title
|
closing and reopening to trigger bots and make sure jenkins is turned off. |
jhamilton1
pushed a commit
to jhamilton1/sonobuoy
that referenced
this pull request
Jun 27, 2018
Update targets and images to use our internal golang 1.9 images Signed-off-by: Jesse Hamilton jesse.hamilton@heptio.com
jhamilton1
pushed a commit
to jhamilton1/sonobuoy
that referenced
this pull request
Jun 27, 2018
Update targets and images to use our internal golang 1.9 images Signed-off-by: Jesse Hamilton jesse.hamilton@heptio.com Signed-off-by: Jesse Hamilton jesse.hamilton@heptio.com
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Timothy St. Clair timothysc@gmail.com
Fixes: #71
/cc @liztio for review.